Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup integration testing #483

Merged
merged 14 commits into from
Sep 4, 2020
Merged

Setup integration testing #483

merged 14 commits into from
Sep 4, 2020

Conversation

appilon
Copy link
Contributor

@appilon appilon commented Sep 1, 2020

This PR sets up helpers and folder structure for integration testing. The example test, tests document symbols which lands in hashicorp/terraform-ls#265.

@appilon appilon requested review from a team and paultyng September 1, 2020 03:51
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will let @aeschright review the TypeScript details but these look sensible on first sight to me and I'm 💯 👍 for improving test coverage in general, so thank you for the work!

The only thing I'm worried about is bundling the 30M provider binary in the extension repo. I assume (hope) that it at least doesn't get included in the package distributed through the Marketplace, but even then my experience is that such technical debt is nearly impossible to address later. i.e. git history is immutable and we'll have to live with that decision practically forever.

Would calling init as part of the test complicate things a lot?

@appilon
Copy link
Contributor Author

appilon commented Sep 1, 2020

@radeksimko great point, that was included mostly by accident, I will amend the setup to calling init as part of the test

aeschright
aeschright previously approved these changes Sep 1, 2020
Copy link
Contributor

@aeschright aeschright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

.gitignore Show resolved Hide resolved
case 'x64':
arch = 'amd64'
break;
case 'x32':
case 'ia32':
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32bit installs were not working

Copy link
Contributor

@aeschright aeschright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@appilon appilon merged commit d9d8fb9 into master Sep 4, 2020
@appilon appilon deleted the integration-tests branch September 4, 2020 18:42
@ghost
Copy link

ghost commented Oct 9, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the context necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Oct 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants