-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add terraform.languageServer.ignoreSingleFileWarning setting #1031
Conversation
Adds the terraform-ls setting that controls whether warnings are shown when editing single Terraform files.
8441fa0
to
440bdd1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one minor question in-line.
"scope": "resource", | ||
"type": "boolean", | ||
"description": "Path to the Terraform binary" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any benefit to setting default: false
here as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good thing you asked, I missed adding a description here.
As for the setting, the const ignoreSingleFileWarning = config('terraform').get<boolean>('languageServer.ignoreSingleFileWarning', false);
line in clientHandler.ts
will ensure we get false if nothing is specified, but it's a good idea to be explicit in both places so I added it.
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Adds the terraform-ls setting that controls whether warnings are shown when editing single Terraform files.
Works with hashicorp/terraform-ls#843