Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add easier way to toggle between terraform-ls / terraform-lsp but keeping auto-updating #335

Closed
paultyng opened this issue Jun 5, 2020 · 4 comments

Comments

@paultyng
Copy link
Contributor

paultyng commented Jun 5, 2020

While the feature sets are diverge more significantly, it may be useful to let users easily opt between language servers (but retaining installation and auto-updating). This should still default to the terraform-ls option.

@paultyng
Copy link
Contributor Author

paultyng commented Jun 5, 2020

I think we probably need a few UI options and some advanced options for this:

UI Options:

  • Language Server: hashicorp/terraform-ls (Default), juliosueiras/terraform-lsp, Manual (set path in advanced), None

Advanced Options

  • Path to binary (for Manual only)
  • Args (for any ls)

Manual would require you to specify a path for it to work, otherwise would have a warning or error.

For terraform-lsp it should use the GitHub release auto updating functionality if possible.

@paultyng
Copy link
Contributor Author

paultyng commented Jun 5, 2020

We need to make sure for the binary path, we are considering the scoping, it probably needs to just be machine, I have issues with the current scoping when I toggle between Windows/WSL.

@paultyng paultyng modified the milestones: v2.0.0, v2.1.0 Jun 9, 2020
@paultyng paultyng removed this from the v2.1.0 milestone Jul 7, 2020
@jpogran
Copy link
Contributor

jpogran commented Jul 5, 2022

We now include terraform-ls in the extension VSIX, so we do not update terraform-ls out of band.

Scoping of machine related settings has been adjusted in #1164, so that part is taken care of now.

VS Code separates extension settings by leading identifier, so terraform.languageServer.pathTobinary is technically a different extension setting than terraform-ls.rootModules. This is an somewhat unwritten convention that is upheld by every extension in existence. We've standardized all the extension names in #1156, so any language server planning on integrating with this extension should use the terraform.languageServer* settings provided here or request an additional setting added for their extension.

This ticket is complete

@jpogran jpogran closed this as completed Jul 5, 2022
@github-actions
Copy link

github-actions bot commented Aug 5, 2022

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants