Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move sdk/helper/random -> helper/random #9226

Merged
merged 2 commits into from
Jun 17, 2020
Merged

Conversation

pcman312
Copy link
Contributor

This package is being moved because this code was originally intended to be used within plugins, however the design of password policies has changed such that this is no longer needed. Thus, this code doesn't need to be in the public SDK.

Note: This package is new for 1.5 so this is not a breaking change.

pcman312 added 2 commits June 15, 2020 11:07
* This package is new for 1.5 so this is not a breaking change.
* This is being moved because this code was originally intended to be used
within plugins, however the design of password policies has changed such
that this is no longer needed. Thus, this code doesn't need to be in the
public SDK.
@pcman312 pcman312 requested a review from a team June 15, 2020 20:32
Copy link

@Valarissa Valarissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tests pass, seems good to go. Was curious about what the test actually confirms when you pass, effectively a stub, to the password generator? Is it ensuring that the password generator is actually using the policy passed to it?

@pcman312
Copy link
Contributor Author

Following up from my offline discussion with @Valarissa:
There are tests in place on the password generation code and the change to StaticSystemView is only used in tests. We lose the connection between the actual generation code in tests that are in the vault package however both sides are still being tested independently. The dynamicSystemView also has tests that are using the real password generation code.

@pcman312 pcman312 merged commit 1508a3b into master Jun 17, 2020
@pcman312 pcman312 deleted the move-password-policies-random branch June 17, 2020 20:24
catsby added a commit that referenced this pull request Jun 19, 2020
* master: (31 commits)
  changelog++
  changelog++
  Ui/replication status discoverability (#8705)
  Update CHANGELOG.md
  Counter that increments on every secret engine lease creation. (#9244)
  Add password_policy field to Azure docs (#9249)
  Replaced ClusterMetricSink's cluster name with an atomic.Value. (#9252)
  Fix database creds rotation panic for nil resp (#9258)
  changelog++
  changelog++
  Move sdk/helper/random -> helper/random (#9226)
  UI: Disallow kv2 with too large 'max versions' value (#9242)
  Allow mTLS for mysql secrets engine (#9181)
  docs: add sample revocation for mongodb (#9245)
  Add new Telemetry config options (#9238)
  Add a simple sealed gauge, updated when seal status changes (#9177)
  Test Shamir-to-Transit and Transit-to-Shamir Seal Migration for post-1.4 Vault. (#9214)
  Configure metrics wrapper with the "global" object, not just the fanout. (#9099)
  changelog++
  Add backend type to audit logs (#9167)
  ...
@pbernal pbernal added this to the 1.5 milestone Jun 22, 2020
andaley pushed a commit that referenced this pull request Jul 17, 2020
* This package is new for 1.5 so this is not a breaking change.
* This is being moved because this code was originally intended to be used
within plugins, however the design of password policies has changed such
that this is no longer needed. Thus, this code doesn't need to be in the
public SDK.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants