Upgrade etcd dependency to v3.3.15 #7403
Conversation
|
Looks like ASF git is having issues right now: https://status.apache.org/incidents/63030p4241xj |
|
Hello, Have you tested this commit your test env? ADDED 1 I still have the issue jsok mentioned. fatal: unable to access 'https://git.apache.org/thrift.git/': Failed to connect to git.apache.org port 443: Connection timed out ADDED 2 google.golang.org/api v0.6.0 |
Even If I use this branch, It is not working great after shutting down one etcd node. |
|
I get a very different set of go.mod changes when I run |
vendoring etcd is a bit confusing to me as well - i've tried to pull We also don't want to just pull from HEAD of master as that's now 3.4.x stream of code and probably larger an upgrade than we need for this fix. |
|
If you pull in from the 3.3.15 tag it is still marked as incompatible but does update deps. I think that's likely the right path for now, assuming you can verify that the pulled in code works properly. |
| golang.org/x/crypto v0.0.0-20190701094942-4def268fd1a4 | ||
| golang.org/x/net v0.0.0-20190620200207-3b0461eec859 | ||
| golang.org/x/net v0.0.0-20190813000000-74dc4d7220e7 | ||
| golang.org/x/oauth2 v0.0.0-20190402181905-9f3314589c9a | ||
| google.golang.org/api v0.5.0 |
go.mod
Outdated
| @@ -42,7 +42,7 @@ require ( | |||
| github.com/go-test/deep v1.0.2 | |||
There was a problem hiding this comment.
for thrift error, as master branch, we need to put below before require block
replace git.apache.org/thrift.git => github.com/apache/thrift v0.12.0
Contains an important fix in clientv3 that allows vault to successfully failover to another etcdv3 endpoint in the event that the current active connection becomes unavailable. See also: * etcd-io/etcd#9949 * etcd-io/etcd#10911 * https://github.com/etcd-io/etcd/blob/master/CHANGELOG-3.3.md#v3314-2019-08-16 Fixes hashicorp#4961
|
Note that things don't actually build successfully just by updating the deps. Making them build likely means essentially reverting the work that was done to adapt to the new APIs and standardizing on the github.com/coreos/etcd repo names, and then changing them back later. The likely better approach is to just go to v3.4.1. Updating to that (and an undeclared but necessary update to google.golang.org/api) gives the following set, which is far more manageable, but also has some deep changes (prometheus, grpc, bbolt): @chrishoffman @briankassouf please weigh in |
|
This is working well in my test. 3 etcd 3.3.15 servers + vault master built with below diff, shutting down etcd server one by one and check
|
|
hmm.. it doesn;t work well on 2nd test. This may be related to mine
|
|
test env, I built test program which is keep asking member list as below built vault with above dependency changes and added my test program works well even if I shutdown one of etcd node one by one several times but vault got error and didn't recovered well ( it is checked with "vault secrets list -detailed" ), it took around 20mins |
@michelvocks that would be fine, I don't think I'll get to it until early next year at this rate. Would also be worth jumping to 3.3.18 too potentially. |
Contains an important fix in clientv3 that allows vault to
successfully failover to another etcdv3 endpoint in the event that the
current active connection becomes unavailable.
See also:
Fixes #4961
Fixed #4349