Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use an array to lookup capabilities paths so that commas aren't an issue #4398

Merged
merged 2 commits into from
Apr 20, 2018

Conversation

meirish
Copy link
Contributor

@meirish meirish commented Apr 19, 2018

This issue here was that the vault server accepts comma-separated strings or an array for capabilities checks. When the path had a comma in it, the server assumed it was a comma-separated string and spit it causing the UI to error out. Now, the UI passes an array so all is right in the world ✨.

Fixes #4395

Copy link
Member

@thrashr888 thrashr888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@meirish meirish merged commit 1ad67cb into master Apr 20, 2018
@meirish meirish deleted the ui-lookup-capabilities branch April 20, 2018 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants