Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Fix OpenApi test for GCP Auth into release/1.19.x #29621

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #29610 to be assessed for backporting due to the inclusion of the label backport/1.19.x.

The below text is copied from the body of the original PR.


Description

These fields were added from PR #29401

Note: there is a known behavior change where if a user submits a default gcp auth config they hit an API error. This is because the backend sees the default of 0 as a value, and both rotation_window and rotation_period cannot be set. This is something the backend will be addressing in a different pr.
image

Confirmed the fields have been added to the auth form.
image
image

  • Note this form is huge and a literal copy/paste of the openApi so it's not very pretty nor helpful.
    image

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

Overview of commits

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/ui/fix-gcp-auth-openapi-params/privately-regular-coral branch from 79bc589 to 0ef1d02 Compare February 13, 2025 19:55
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Feb 13, 2025
Copy link

Build Results:
All builds succeeded! ✅

Copy link

CI Results:
All Go tests succeeded! ✅

@Monkeychip Monkeychip added this to the 1.19.0-rc milestone Feb 13, 2025
@Monkeychip Monkeychip merged commit 61d457f into release/1.19.x Feb 13, 2025
33 of 35 checks passed
@Monkeychip Monkeychip deleted the backport/ui/fix-gcp-auth-openapi-params/privately-regular-coral branch February 13, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants