Backport of Fix OpenApi test for GCP Auth into release/1.19.x #29621
+28
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #29610 to be assessed for backporting due to the inclusion of the label backport/1.19.x.
The below text is copied from the body of the original PR.
Description
These fields were added from PR #29401
Note: there is a known behavior change where if a user submits a default gcp auth config they hit an API error. This is because the backend sees the default of
![image](https://private-user-images.githubusercontent.com/6618863/412981840-405f6b89-2f0c-4f41-86b1-40bb5d6d4435.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk5NzkyNDYsIm5iZiI6MTczOTk3ODk0NiwicGF0aCI6Ii82NjE4ODYzLzQxMjk4MTg0MC00MDVmNmI4OS0yZjBjLTRmNDEtODZiMS00MGJiNWQ2ZDQ0MzUucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxOSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTlUMTUyOTA2WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9N2QzODhiZDhiNTVhNGNkYmEyZTEwNGEzOTkwNTQxZjgwNzdlMDI0MTI4YzUyM2ZjODYyZmNiMGJmYzRlNmE1NyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.2sJU3RP5mguQAKESYfWtjkRW-G24ENovnKo3xszQIiU)
0
as a value, and bothrotation_window
androtation_period
cannot be set. This is something the backend will be addressing in a different pr.Confirmed the fields have been added to the auth form.
![image](https://private-user-images.githubusercontent.com/6618863/412979897-8995f939-ded4-4a64-8658-c4232f8ff62d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk5NzkyNDYsIm5iZiI6MTczOTk3ODk0NiwicGF0aCI6Ii82NjE4ODYzLzQxMjk3OTg5Ny04OTk1ZjkzOS1kZWQ0LTRhNjQtODY1OC1jNDIzMmY4ZmY2MmQucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxOSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTlUMTUyOTA2WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZGRjNjYwNGQ2NjE0ZWVmNzRlNGIzYjMzMDZmZTgyNzI1YWI3YjA4MzU0NTZmNzgzZTc1NjEzZWM0ZGQxMDUyMCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.hsIui-NPrMxHOiPWYRR0nolz0MG5uP7GsKjcCJkvDg4)
![image](https://private-user-images.githubusercontent.com/6618863/412980500-2e3f7552-1376-43f8-afeb-4a46c966e0c8.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk5NzkyNDYsIm5iZiI6MTczOTk3ODk0NiwicGF0aCI6Ii82NjE4ODYzLzQxMjk4MDUwMC0yZTNmNzU1Mi0xMzc2LTQzZjgtYWZlYi00YTQ2Yzk2NmUwYzgucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxOSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTlUMTUyOTA2WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YzZjMzJhM2UwMThmYWNhNGYzMmE5YTJiZDRiMTg0YmM4ZDgwOWRjNGNkMGM2N2JhNDJhMDMzMTQxNTNlN2JlMSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.0ONtW8OluypEKCPbKFg221mH1wq0LAm3qI8NwjWIYco)
TODO only if you're a HashiCorp employee
backport/
label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x
, but older release branches will bebackport/ent/x.x.x+ent
.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.
Overview of commits