Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add underlining support for the PKI Enterprise SCEP work #29604

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

stevendpclark
Copy link
Contributor

Description

This adds some underlining work within the PKI engine and PKCS7 library to support the Enterprise PKI SCEP work that is ongoing.

  • PKCS7 library
    • Allow per call encryption selection instead of updating a global variable
    • Add 3DES encryption support
  • PKI
    • Move around existing code within the issuing package out of the main pki package so other pki sub-packages can use it
    • Add a helper ASN.1 method that will mimic asn1.Unmarshal but also error out on trailing data.

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@stevendpclark stevendpclark self-assigned this Feb 13, 2025
@stevendpclark stevendpclark requested review from a team as code owners February 13, 2025 15:25
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Feb 13, 2025
helper/pkcs7/encrypt.go Dismissed Show dismissed Hide dismissed
helper/pkcs7/encrypt.go Dismissed Show dismissed Hide dismissed
Copy link

CI Results:
All Go tests succeeded! ✅

@stevendpclark stevendpclark enabled auto-merge (squash) February 13, 2025 15:51
Copy link

Build Results:
All builds succeeded! ✅

@stevendpclark stevendpclark merged commit ce8094f into main Feb 13, 2025
103 checks passed
@stevendpclark stevendpclark deleted the stevendpclark/vault-27891-scep-support branch February 13, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog pr/no-milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants