Backport of Fix issue caused by group-creation forwarding. into release/1.19.x

[hc-github-team-secure-vault-core]

Backport

This PR is auto-generated from #29559 to be assessed for backporting due to the inclusion of the label backport/1.19.x.

The below text is copied from the body of the original PR.

---

Description

Fixes a bug introduced in #29483. That PR included an attempt to prevent duplicate groups with different IDs being created by a race condition, however that fix interferes in a subtle way when duplicate groups (causes by historical bugs, like the one it was trying to fix) are already present in storage. It turns out that that code was not actually necessary for the fix - removing it doesn't make any of the test cases added in https://github.com/hashicorp/vault-enterprise/pull/6990 fail - I ran them over 40 times each locally with no failures.

This PR also fixes up the URL in the reports since the docs were moved around.

Fixes VAULT-33879. This also fixes a bunch of potential new issues in the case that duplicate groups already exist - before this fix they would have loaded the contents of one group but swapped it's ID for another duplicate which is even more confusing and problematic than before!

There is no Enterprise part to this PR exactly, however while working on this I realised we deprecated an RPC and so will make a PR to remove it and make it error to avoid unexpected behavior during mixed version upgrade scenarios.

@biazmoreira The one thing you mentioned that I didn't get to was that we potentially missed some of the group-alias endpoints in the original PR. I took a quick look and it certainly does look like there are a couple of code paths there that get to doing an UpsertGroup which will no longer forward at the RPC level and are potentially even more broken than before because of that by #29483. Could you take a look? We can include that in this PR if so.

TODO

• Add forwarding to necessary group-alias endpoints too.

TODO only if you're a HashiCorp employee

• Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
  • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
• ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
  of a public function, even if that change is in a CE file, double check that
  applying the patch for this PR to the ENT repo and running tests doesn't
  break any tests. Sometimes ENT only tests rely on public functions in CE
  files.
• Jira: If this change has an associated Jira, it's referenced either
  in the PR description, commit message, or branch name.
• RFC: If this change has an associated RFC, please link it in the description.
• ENT PR: If this change has an associated ENT PR, please link it in the
  description. Also, make sure the changelog is in this PR, not in your ENT PR.

---

Overview of commits

• f4d73bb

[github-actions]

CI Results:
All Go tests succeeded! ✅

[github-actions]

Build Results:
All builds succeeded! ✅