Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VAULT-33603: normalize start time in export api #29562

Merged
merged 2 commits into from
Feb 12, 2025

Conversation

aslamovamir
Copy link
Contributor

@aslamovamir aslamovamir commented Feb 11, 2025

Description

What does this PR do?
The export API will return different results than the sys/counters API when using a date that is in the middle of the month; to fix this, we should normalize the start_date parameter to the start of the month as is done in the sys/counters API.

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@aslamovamir aslamovamir requested a review from a team as a code owner February 11, 2025 21:56
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Feb 11, 2025
Copy link

github-actions bot commented Feb 11, 2025

Build Results:
All builds succeeded! ✅

Copy link

github-actions bot commented Feb 11, 2025

CI Results:
All Go tests succeeded! ✅

@divyaac
Copy link
Contributor

divyaac commented Feb 11, 2025

Pending all tests passing - looks good to me!

Copy link
Contributor

@divyaac divyaac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending all tests passing - looks good to me!

@aslamovamir aslamovamir added backport/1.18.x backport/1.19.x backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent backport/ent/1.17.x+ent Changes are backported to 1.17.x+ent labels Feb 12, 2025
@aslamovamir aslamovamir merged commit 6a30d4e into main Feb 12, 2025
116 of 117 checks passed
@aslamovamir aslamovamir deleted the aslamovamir-hvt-33603-normalize-start-date-export branch February 12, 2025 20:16
drivera258 pushed a commit that referenced this pull request Feb 13, 2025
* copy subset of oss changes from ent pr

* add changelog entree
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent backport/ent/1.17.x+ent Changes are backported to 1.17.x+ent backport/1.18.x backport/1.19.x hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants