Add automated root rotation support to DB Secrets #29557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
vinay-gopalan
requested review from
kpcraig and
robmonte
and removed request for
lursu
|
CI Results: |
|
Build Results: |
robmonte
reviewed
Feb 11, 2025
kpcraig
reviewed
Feb 11, 2025
kpcraig
reviewed
Feb 11, 2025
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
I don't love that we've got the db changes, and some sdk changes in the same PR but I understand we're down to the wire here. |
kpcraig
approved these changes
Feb 11, 2025
vinay-gopalan
deleted the
VAULT-33367/automated-root-rotation-db-secrets
branch
vinay-gopalan
added a commit
that referenced
this pull request
Feb 12, 2025
vinay-gopalan
added a commit
that referenced
this pull request
Feb 12, 2025
drivera258
pushed a commit
that referenced
this pull request
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds automated root rotation support to DB Secrets
Other changes: