Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api-client): add cert auth method #29546

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

witochandra
Copy link

@witochandra witochandra commented Feb 11, 2025

Description

This PR adds cert auth method in the vault/api/auth. #29544

https://developer.hashicorp.com/vault/api-docs/auth/cert#login-with-tls-certificate-method

@witochandra witochandra requested a review from a team as a code owner February 11, 2025 12:37
@witochandra witochandra requested a review from rebwill February 11, 2025 12:37
Copy link

hashicorp-cla-app bot commented Feb 11, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


Wito Chandra seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA.
If you have already a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

@witochandra witochandra force-pushed the feat/api-client-add-cert-auth-method branch from 3a7fea6 to 135bd95 Compare February 12, 2025 05:30
api/auth/cert/cert.go Outdated Show resolved Hide resolved
api/auth/cert/cert.go Outdated Show resolved Hide resolved
api/auth/cert/cert.go Outdated Show resolved Hide resolved
api/auth/cert/cert.go Outdated Show resolved Hide resolved
api/auth/cert/cert.go Outdated Show resolved Hide resolved
api/auth/cert/cert.go Outdated Show resolved Hide resolved
Copy link
Contributor

@aslamovamir aslamovamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Thanks for creating this. Left some comments for improvement.

@aslamovamir
Copy link
Contributor

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Wito Chandra seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

@witochandra Can you please address these concerns as well? We need to this to proceed with your PR.

@aslamovamir
Copy link
Contributor

@witochandra please feel free to tag me when reviewing the feedback. Thanks again!

@aslamovamir
Copy link
Contributor

@witochandra
Copy link
Author

CLA assistant check
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement
Learn more about why HashiCorp requires a CLA and what the CLA includes
Wito Chandra seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
Have you signed the CLA already but the status is still pending? Recheck it.

@witochandra Can you please address these concerns as well? We need to this to proceed with your PR.

I have addressed that, but I'm not sure what is still pending. 🤔

There were two comments from that bot. One mentioned that I have signed the CLA, while the other stated that I haven't.

Maybe there is a bug in the bot? 😅

Additionally, the email associated with the commits is from my GitHub account.

changelog/29546.txt Outdated Show resolved Hide resolved
@aslamovamir
Copy link
Contributor

CLA assistant check
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement
Learn more about why HashiCorp requires a CLA and what the CLA includes
Wito Chandra seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
Have you signed the CLA already but the status is still pending? Recheck it.

@witochandra Can you please address these concerns as well? We need to this to proceed with your PR.

I have addressed that, but I'm not sure what is still pending. 🤔

There were two comments from that bot. One mentioned that I have signed the CLA, while the other stated that I haven't.

Maybe there is a bug in the bot? 😅

Additionally, the email associated with the commits is from my GitHub account.

Hmm interesting, maybe try to sign again? There is also the link to Recheck it, can you please trying that?

@witochandra
Copy link
Author

CLA assistant check
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement
Learn more about why HashiCorp requires a CLA and what the CLA includes
Wito Chandra seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
Have you signed the CLA already but the status is still pending? Recheck it.

@witochandra Can you please address these concerns as well? We need to this to proceed with your PR.

I have addressed that, but I'm not sure what is still pending. 🤔
There were two comments from that bot. One mentioned that I have signed the CLA, while the other stated that I haven't.
Maybe there is a bug in the bot? 😅
Additionally, the email associated with the commits is from my GitHub account.

Hmm interesting, maybe try to sign again? There is also the link to Recheck it, can you please trying that?

Have tried both.

When I clicked the read & sign button, it showed a form that I have filled & signed.

When I clicked the recheck link, it redirected to this PR page.

In the github action, it showed that the CLA has been signed too.

Github Action

Maybe bug in the bot? 😅

Copy link
Contributor

@aslamovamir aslamovamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution, @witochandra! Your PR looks good to me and we can go ahead with merging!

@aslamovamir
Copy link
Contributor

CLA assistant check
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement
Learn more about why HashiCorp requires a CLA and what the CLA includes
Wito Chandra seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
Have you signed the CLA already but the status is still pending? Recheck it.

@witochandra Can you please address these concerns as well? We need to this to proceed with your PR.

I have addressed that, but I'm not sure what is still pending. 🤔
There were two comments from that bot. One mentioned that I have signed the CLA, while the other stated that I haven't.
Maybe there is a bug in the bot? 😅
Additionally, the email associated with the commits is from my GitHub account.

Hmm interesting, maybe try to sign again? There is also the link to Recheck it, can you please trying that?

Have tried both.

When I clicked the read & sign button, it showed a form that I have filled & signed.

When I clicked the recheck link, it redirected to this PR page.

In the github action, it showed that the CLA has been signed too.

Github Action

Maybe bug in the bot? 😅

Hmmm this is strange, maybe a not surprise from GitHub pipelines sometimes 😄

@aslamovamir aslamovamir reopened this Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants