Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of UI: Use timestamp.now() in custom messages into release/1.18.x #29531

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #29525 to be assessed for backporting due to the inclusion of the label backport/1.18.x.

The below text is copied from the body of the original PR.


Description

This replaces new Date() with timestamp.now() which can be more reliable stubbed in tests. See #19521 for more context

✅ enterprise tests (because of timezone weirdness, double checked enterprise tests by opening a PR to the enterprise repo)

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

Overview of commits

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/ui/VAULT-33866/fix-timestamp-custom-messages/repeatedly-proud-bluebird branch from 428a00f to 55b94c6 Compare February 7, 2025 23:47
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Feb 7, 2025
Copy link

github-actions bot commented Feb 7, 2025

Build Results:
All builds succeeded! ✅

Copy link

github-actions bot commented Feb 8, 2025

CI Results:
All Go tests succeeded! ✅

@hellobontempo hellobontempo added this to the 1.18.5 milestone Feb 10, 2025
…amp-custom-messages/repeatedly-proud-bluebird
@hellobontempo hellobontempo enabled auto-merge (squash) February 10, 2025 19:52
@hellobontempo hellobontempo merged commit b11bb45 into release/1.18.x Feb 10, 2025
24 checks passed
@hellobontempo hellobontempo deleted the backport/ui/VAULT-33866/fix-timestamp-custom-messages/repeatedly-proud-bluebird branch February 10, 2025 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants