Automated rotate root support for AWS Auth and Secrets #29497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results: |
|
Build Results: |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…n tests; add error log on storage failures
vinay-gopalan
commented
Feb 7, 2025
| @@ -13,7 +13,7 @@ import ( | |||
| const ( | |||
| // Minimum allowed value for rotation_window | |||
| minRotationWindowSeconds = 3600 | |||
| parseOptions = cron.Second | cron.Minute | cron.Hour | cron.Dom | cron.Month | cron.Dow | |||
| parseOptions = cron.Minute | cron.Hour | cron.Dom | cron.Month | cron.Dow | |||
There was a problem hiding this comment.
In production, schedules using seconds should be disallowed. Only useful in testing. Matches behavior with the DB Engine as well
kpcraig
reviewed
Feb 7, 2025
| } | ||
| } | ||
|
|
||
| if region, ok := data.GetOk("region"); ok { |
There was a problem hiding this comment.
Does updating the data extraction like this change any of the user-facing behaviors?
robmonte
reviewed
Feb 10, 2025
vinay-gopalan
changed the title
robmonte
previously approved these changes
Feb 10, 2025
kpcraig
approved these changes
Feb 10, 2025
vinay-gopalan
deleted the
VAULT-33367/automated-root-rotation-aws-auth
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds new support for using Automated Rotation with AWS Auth and DB Secrets.
Note: This feature is Enterprise only and will only work with an Enterprise Vault instance. Tests for the feature will also be added against Vault Enterprise once this PR is merged.
Other changes:
MountPointinstead ofMountTypeto correctly route requests to custom mount aliases (eg:foo/bar/baz/config)