VAULT-33693 actions: fix push event PR labels #29476
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryancragun
added
pr/no-changelog
pr/no-milestone
backport/ent/1.16.x+ent
github-actions
bot
added
the
hashicorp-contributed-pr
|
An example of the equivalent query manually. In this case we're looking for the labels associated with release SHA for Vault 1.18.4+ent and it correctly resolves the |
ryancragun
changed the title
rebwill
previously approved these changes
Jan 31, 2025
|
CI Results: |
|
Build Results: |
tvo0813
previously approved these changes
Jan 31, 2025
charlesn-hc
previously approved these changes
Jan 31, 2025
ryancragun
dismissed stale reviews from charlesn-hc, tvo0813, and rebwill
via
ef4ed05
ryancragun
force-pushed
the
VAULT-33693
branch
from
ef4ed05 to
4ef0a92
Compare
|
Simplified the query a bit more and made it easier to pull out for local exec |
ryancragun
force-pushed
the
VAULT-33693
branch
from
4ef0a92 to
91e0103
Compare
rebwill
approved these changes
Feb 11, 2025
charlesn-hc
approved these changes
Feb 11, 2025
Fix pull request label metadata when triggered `push` event types. We now use Github's `associatedPullRequests()` connection on the `Commit` associated with the SHA to resolve the labels. Signed-off-by: Ryan Cragun <[email protected]>
Signed-off-by: Ryan Cragun <[email protected]>
ryancragun
force-pushed
the
VAULT-33693
branch
from
91e0103 to
0aca520
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix pull request label metadata when triggered by
pushevent types. We now use Github'sassociatedPullRequests()connection on theCommitassociated with the SHA to resolve the labels.TODO only if you're a HashiCorp employee
backport/label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x, but older release branches will bebackport/ent/x.x.x+ent.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.