Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign empty to cert on manual-chain update. #29473

Conversation

kitography
Copy link
Contributor

Description

What does this PR do?

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jan 31, 2025
Copy link

github-actions bot commented Jan 31, 2025

CI Results:
All Go tests succeeded! ✅

@kitography kitography added this to the 1.19.0-rc milestone Jan 31, 2025
@kitography kitography force-pushed the VAULT-33253-check-the-manual-chain-validates-the-issuer-when-set branch 3 times, most recently from 5429bb7 to 0277f2f Compare February 5, 2025 19:14
@kitography kitography marked this pull request as ready for review February 5, 2025 19:14
@kitography kitography requested review from a team as code owners February 5, 2025 19:14
Copy link

github-actions bot commented Feb 5, 2025

Build Results:
All builds succeeded! ✅

@kitography kitography force-pushed the VAULT-33253-check-the-manual-chain-validates-the-issuer-when-set branch 2 times, most recently from c82d69c to db2e66b Compare February 6, 2025 18:58
@kitography kitography merged commit 49ecdad into main Feb 10, 2025
91 of 92 checks passed
@kitography kitography deleted the VAULT-33253-check-the-manual-chain-validates-the-issuer-when-set branch February 10, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants