Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add identity cleanup activation flag #29301

Merged
merged 4 commits into from
Jan 9, 2025
Merged

Conversation

biazmoreira
Copy link
Contributor

@biazmoreira biazmoreira commented Jan 6, 2025

Description

Add identity cleanup activation flag.

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@biazmoreira biazmoreira requested a review from a team as a code owner January 6, 2025 23:15
@biazmoreira biazmoreira requested review from yankun91 and removed request for a team January 6, 2025 23:15
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jan 6, 2025
@biazmoreira biazmoreira requested review from banks and mpalmi and removed request for yankun91 January 6, 2025 23:15
@biazmoreira biazmoreira added this to the 1.19.0-rc milestone Jan 6, 2025
Copy link

github-actions bot commented Jan 6, 2025

CI Results:
All Go tests succeeded! ✅

Copy link

github-actions bot commented Jan 6, 2025

Build Results:
All builds succeeded! ✅

Copy link
Member

@banks banks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. I think the only thing is the flag name which we called force-identity-deduplication in the RFC and docs for clarity.

vault/logical_system_activation_flags.go Outdated Show resolved Hide resolved
@biazmoreira biazmoreira force-pushed the biazmoreira/activation-flag/1 branch from dd4ad0a to 114c46b Compare January 8, 2025 18:31
@biazmoreira biazmoreira force-pushed the biazmoreira/activation-flag/2 branch from b9d0f3c to cddd55b Compare January 9, 2025 11:29
Base automatically changed from biazmoreira/activation-flag/1 to main January 9, 2025 13:28
@biazmoreira biazmoreira force-pushed the biazmoreira/activation-flag/2 branch from cddd55b to b821354 Compare January 9, 2025 15:00
@biazmoreira biazmoreira requested a review from banks January 9, 2025 15:25
Copy link
Member

@banks banks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@biazmoreira biazmoreira merged commit 80fe86a into main Jan 9, 2025
95 of 97 checks passed
@biazmoreira biazmoreira deleted the biazmoreira/activation-flag/2 branch January 9, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants