Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log when the seal is unavailable as error #28564

Merged
merged 3 commits into from
Oct 3, 2024

Conversation

sgmiller
Copy link
Collaborator

@sgmiller sgmiller commented Oct 2, 2024

Description

Vault's seal health checking is advisory, meaning it doesn't affect the operation of Vault to detect an unhealthy seal. As such we originally logged failures as Warn. In particular, we only logged at Warn level the message indicating all seals are unhealthy, which is a bad situation for operators. This quick PR changes that line to ERROR to make it easier for operators to spot. Addresses SR-175.

TODO only if you're a HashiCorp employee

  • Backport Labels: If this PR is in the ENT repo and needs to be backported, backport
    to N, N-1, and N-2, using the backport/ent/x.x.x+ent labels. If this PR is in the CE repo, you should only backport to N, using the backport/x.x.x label, not the enterprise labels.
    • If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@sgmiller sgmiller requested a review from a team as a code owner October 2, 2024 18:25
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Oct 2, 2024
@sgmiller sgmiller modified the milestones: 1.18.0, 1.19.0-rc Oct 2, 2024
Copy link

github-actions bot commented Oct 2, 2024

CI Results:
All Go tests succeeded! ✅

Copy link

github-actions bot commented Oct 2, 2024

Build Results:
All builds succeeded! ✅

changelog/28564.txt Outdated Show resolved Hide resolved
Co-authored-by: Steven Clark <[email protected]>
@sgmiller sgmiller enabled auto-merge (squash) October 3, 2024 18:28
@sgmiller sgmiller merged commit 1eaca82 into main Oct 3, 2024
83 checks passed
@sgmiller sgmiller deleted the sgm/vault-29866/log-hsm-failures-as-error branch October 3, 2024 18:47
@sgmiller sgmiller added backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent and removed backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent labels Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent backport/1.18.x hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants