Backport of UI Hide Secrets Sync from nav if not on license and/or no policy permissions into release/1.17.x #27436
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #27262 to be assessed for backporting due to the inclusion of the label backport/1.17.x.
The below text is copied from the body of the original PR.
Adding Do not merge label so this is target for 1.17.1 and does not get into GA.
This PR hides Secrets Sync from the sidebar navigation under the following circumstances. The decisions was made to remove the upsell badges because showing Secrets Sync to users who do not have this feature or have the feature but do not have any access to the
sys/sync
endpoint is an anti-pattern to how the UI currently handles showing/hiding features.Notes:
These changes do the following:
Hides Secrets Sync nav from all OSS users.

Displays only one upsell badge for HVD managed clusters. We cannot tell which tier they are on. In the future this will likely change.

If you're an Enterprise user without Secrets Sync on your license, you will not see it in the sidebar nav.

If you're an Enterprise user with Secrets Sync on your license and it's NOT activated, you will see the sidebar nav (regardless of your policy permissions).
Below is a user Bob with the ability to read on sys/sync/destinations only, and he can see it.
Below is a user Maria with the default policy (no access to sys/sync), she can not see it.

Overview of commits