Gate sync overview route for users without access #27320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results: failed ❌ |
|
Build Results: |
hashishaw
suggested changes
Jun 3, 2024
andaley
merged commit 51bf477
into
ui/VAULT-27608/hide-secrets-sync-when-no-access
20 of 23 checks passed
Monkeychip
added a commit
that referenced
this pull request
Jun 11, 2024
…issions (#27262) * intial changes, haven't tested client counts or done test coverage * client count rename getter to clairfy * fix has-permission api-paths * wip * wip * fix: explicitly refresh vault.cluster model to re-fetch activatedFeatures after actication * tests: fix # of assertions for verifying that activation was called * tests: tidy overview-test * add additional api permission path and move fetch back to application * add test coverage for the service * cleanup * remove test that checked for upsell without license or on community * small comment change * welp missed component getter * flaky test fix * flaky test * small nit changes from pr reviews * add defaults to sync mirage handler * Gate sync overview route for users without access (#27320) * routes: add redirect if user does not have access to sync * tests: verify redirect on sync overview page happens * tests: organize tests modules to ensure enterprise is explicitly set up * add type enterprise required now because we do a check for this first * fix oss test --------- Co-authored-by: Noelle Daley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Description
Adds a secondary layer of protection to the Sync overview page, ensuring users can't access the page by pasting the URL directly.
🔗 Links
Follow up to https://github.com/hashicorp/vault/pull/27262/files
📸 Screenshots
Ent tests pass locally except for unrelated replication / kv tests
🏗️ How to Build and Test the Change
🚫 Using an OSS cluster, verify you cannot directly access
http://localhost:4200/ui/vault/sync/secrets/overview.✅ Using an ENT cluster, verify you can access
http://localhost:4200/ui/vault/sync/secrets/overview(and see "sync" in the sidebar).