Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Fix copy button for PKI ca_chain certificate card #25399

Merged
merged 5 commits into from
Feb 14, 2024

Conversation

hellobontempo
Copy link
Contributor

@hellobontempo hellobontempo commented Feb 13, 2024

Fixes a bug where PKI ca_chain data was not copyable because it is an array

Screenshot 2024-02-14 at 9 54 44 AM

with fix 🔧

Screenshot 2024-02-14 at 9 55 17 AM

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Feb 13, 2024
Copy link

Build Results:
All builds succeeded! ✅

Copy link

CI Results:
All Go tests succeeded! ✅

@@ -77,7 +77,7 @@
}

.is-medium-width {
width: calc($desktop / 3);
width: calc($desktop / 2.5);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

longer formats went to a new line, so made the card a little wider (before KEY ---- was a new line)
Screenshot 2024-02-14 at 9 57 07 AM

@hellobontempo hellobontempo added this to the 1.15.6 milestone Feb 14, 2024
@hellobontempo hellobontempo changed the title UI: create format-copy-value helper for Hds::Copy::Button text UI: Fix copy button for PKI ca_chain certificate card Feb 14, 2024
@hellobontempo hellobontempo merged commit 2f2e018 into main Feb 14, 2024
31 checks passed
@hellobontempo hellobontempo deleted the ui/VAULT-24065/fix-certificate-card-copy-button branch February 14, 2024 19:04
@hellobontempo hellobontempo modified the milestones: 1.15.6, 1.16.0 Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants