Request Limiter reloadable config #25095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results: |
mpalmi
force-pushed
the
request-limiter-reloadable-config
branch
from
c97d244 to
c46ca85
Compare
mpalmi
force-pushed
the
request-limiter-reloadable-config
branch
from
ea6671b to
5c6b0f9
Compare
raskchanky
approved these changes
Jan 26, 2024
| return ValidateUnusedFields(r.UnusedKeys, source) | ||
| } | ||
|
|
||
| func (r *RequestLimiter) GoString() string { |
There was a problem hiding this comment.
Maybe for tests? Truthfully not sure, but other configs used this so I followed suit.
| if result.RequestLimiter.Disable, err = parseutil.ParseBool(result.RequestLimiter.DisableRaw); err != nil { | ||
| return err | ||
| } | ||
| result.RequestLimiter.DisableRaw = nil |
There was a problem hiding this comment.
Is this a common pattern, setting it to nil after parsing it? I haven't seen that before.
There was a problem hiding this comment.
Yeah, for some reason we clear the raw entry after parsing. I'm not sure I understand it, but copied it from other implementations.
|
Build Results: |
Monkeychip
pushed a commit
that referenced
this pull request
Jan 29, 2024
This commit introduces a new reloadable stanza to the server config to allow disabling the Request Limiter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on top of #25093 to establish a reloadable break-glass config for disabling the request limiter.
Two follow-up PRs are needed: