Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Fixed Oauth redirect not working on Android Chrome into release/1.13.x #24713

Merged

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #18513 to be assessed for backporting due to the inclusion of the label backport/1.13.x.

The below text is copied from the body of the original PR.


This fixes the issue described in #16778. Navigation is blocked in Android chrome while redirecting back after OIDC authentication. The issue is explained by the lead maintainer of
AppAuth(https://stackoverflow.com/a/41882732).
The latest Chrome version redirects to the app only if triggered by the user and not automatically redirect. Hence, a link is added in the UI to redirect back to the app.


Overview of commits

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/vaultauthredirect/blindly-new-racer branch from 76bc9d0 to b3c94de Compare January 8, 2024 19:22
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jan 8, 2024
@hashishaw hashishaw added this to the 1.13.13 milestone Jan 8, 2024
@hashishaw hashishaw added ui backport bug Used to indicate a potential bug labels Jan 8, 2024
Copy link

github-actions bot commented Jan 8, 2024

Build Results:
All builds succeeded! ✅

@hashishaw hashishaw merged commit d6c75ff into release/1.13.x Jan 9, 2024
64 checks passed
@hashishaw hashishaw deleted the backport/vaultauthredirect/blindly-new-racer branch January 9, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport bug Used to indicate a potential bug hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants