Glimmerize Splash Page #24104
Merged
Glimmerize Splash Page #24104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
|
Build Results: |
hashishaw
suggested changes
Nov 15, 2023
hashishaw
reviewed
Nov 20, 2023
hashishaw
approved these changes
Nov 27, 2023
| SPDX-License-Identifier: BUSL-1.1 | ||
| ~}} | ||
|
|
||
| <div class="splash-page-container section is-flex-v-centered-tablet is-flex-grow-1 is-fullwidth"> |
There was a problem hiding this comment.
So much cleaner without altContent! 👏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a good candidate for a display only component that yielded from named blocks. Feels good to remove three js files that were tagName only.
Note: Because
altContentis specific only to auth.hbs, I moved it outside the SplashPage component (thank you Chelsea for the suggestion). There is a mfa acceptance test that tests for this error message and the Go Back functionality.Ran enterprise test locally, they passed.
MFA had a param that was not being used:
showTruncatedNavBar. Still looks as expected, see screenshot.