VAULT-3825: Wildcard ACL policies without a trailing slash should match LIST operations #23874
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a LIST operation is executed on namespace foo, both of the following policies will independently allow the operation:
and
both work 👍
However, when we use a wildcard in the policy path, we get different behavior:
^ this fails
but ^ this succeeds.
This PR fixes the behavior so that it's the same for a wildcard versus no wildcard.
I considered stripping the trailing slash earlier in the request flow, but that would mean that any users that had written rules assuming that there was a trailing slash would need to update their policies after this change.
Tests for this are in enterprise.