Backport of Forbid setting auto_rotate_period on transit managed keys into release/1.13.x #23744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-secure-vault-core
requested a review
from a team
as a code owner
hc-github-team-secure-vault-core
force-pushed
the
backport/stevendpclark/vault-21223-transit-fixes/steadily-allowing-unicorn
branch
from
2a1a82e to
2891730
Compare
hc-github-team-secure-vault-core
force-pushed
the
backport/stevendpclark/vault-21223-transit-fixes/steadily-allowing-unicorn
branch
from
301759b to
eeb19df
Compare
github-actions
bot
added
the
hashicorp-contributed-pr
stevendpclark
approved these changes
Oct 19, 2023
|
Build Results: |
stevendpclark
deleted the
backport/stevendpclark/vault-21223-transit-fixes/steadily-allowing-unicorn
branch
|
CI Results: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #23723 to be assessed for backporting due to the inclusion of the label backport/1.13.x.
The below text is copied from the body of the original PR.
Prevent and guard against auto-rotating managed keys as we generate an invalid key version without the UUID field set.
Hook in the datakey generation api into managed key encryption.
Tests will come within a seperate enterprise PR
Overview of commits