Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Show unsupported screen if replication unsupported #23178

Merged

Conversation

hashishaw
Copy link
Contributor

On Enterprise, if replication is unsupported the user can still go to the replication page, but it would look like it loads forever. This fix correctly shows the "unsupported" screen if replication status returns mode: unsupported

Screenshot 2023-09-19 at 3 51 57 PM

@hashishaw hashishaw added ui bug Used to indicate a potential bug backport/1.13.x labels Sep 19, 2023
@hashishaw hashishaw added this to the 1.13.8 milestone Sep 19, 2023
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Sep 19, 2023
@github-actions
Copy link

Build Results:
All builds succeeded! ✅

Copy link
Contributor

@zofskeez zofskeez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great and thanks for the test! 🎉

@hashishaw hashishaw merged commit f2be122 into main Sep 20, 2023
@hashishaw hashishaw deleted the ui/VAULT-20180/fix-replication-hanging-when-unsupported branch September 20, 2023 14:05
zofskeez pushed a commit that referenced this pull request Sep 22, 2023
* UI: Show unsupported screen if replication unsupported (#23178)

* UI: add pagination to new PKI (#23193)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Used to indicate a potential bug hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants