Correct the post-unseal meaning of the seal status type #23022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And at the same time add a RecoverySealType to the response which preserves the old meaning. Updated the CLI to display both when relevant.
github-actions
bot
added
the
hashicorp-contributed-pr
|
Build Results: |
|
CI Results: |
stevendpclark
approved these changes
Oct 5, 2023
victorr
pushed a commit
that referenced
this pull request
Nov 16, 2023
* Correct the post-unseal meaning of the seal status type And at the same time add a RecoverySealType to the response which preserves the old meaning. Updated the CLI to display both when relevant. * changelog * no longer needed * Don't need this field either, which fixes unit tests * fix unit tests
victorr
added a commit
that referenced
this pull request
Nov 16, 2023
…nto release/1.15.x (#24170) * Correct the post-unseal meaning of the seal status type (#23022) * Correct the post-unseal meaning of the seal status type And at the same time add a RecoverySealType to the response which preserves the old meaning. Updated the CLI to display both when relevant. * changelog * no longer needed * Don't need this field either, which fixes unit tests * fix unit tests --------- Co-authored-by: Scott Miller <[email protected]> Co-authored-by: Victor Rodriguez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And at the same time add a RecoverySealType to the response which preserves the old meaning.
Updated the CLI to display both when relevant.