events: WebSocket subscriptions support go-bexpr expressions #22835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
swenson
force-pushed
the
vault-19136/events-b-expr
branch
from
b328d7a to
2aaf6ec
Compare
|
Build Results: |
|
CI Results: |
swenson
force-pushed
the
vault-19136/events-b-expr
branch
from
2aaf6ec to
4f9db8b
Compare
tomhjp
approved these changes
Sep 7, 2023
go.mod
Outdated
| @@ -380,6 +380,7 @@ require ( | |||
| github.com/gsterjov/go-libsecret v0.0.0-20161001094733-a6f4afe4910c // indirect | |||
| github.com/hailocab/go-hostpool v0.0.0-20160125115350-e80d13ce29ed // indirect | |||
| github.com/hashicorp/cronexpr v1.1.1 // indirect | |||
| github.com/hashicorp/go-bexpr v0.1.12 // indirect | |||
There was a problem hiding this comment.
nit: Indirect seems weird, does this need a go mod tidy?
There was a problem hiding this comment.
Good call. I re-ran go mod tidy and it moved it to a direct dependency.
sdk/logical/events.go
Outdated
| EventType string `bexpr:"event_type"` | ||
| Operation string `bexpr:"operation"` | ||
| SourcePluginMount string `bexpr:"source_plugin_mount"` | ||
| FullSecretPath string `bexpr:"full_secret_path"` |
There was a problem hiding this comment.
Any reason not to use data_path for consistency? I know data_path starts its life from the plugin as not a full path, but from an end user's point of view it always ends up being a full path once we've updated it right?
There was a problem hiding this comment.
Good call. I was mostly just copy-pasting from the RFC, but we should strive for consistency.
swenson
force-pushed
the
vault-19136/events-b-expr
branch
from
4f9db8b to
f496554
Compare
added 3 commits
September 7, 2023 11:07
Subscribing to events through a WebSocket now support boolean expressions to filter only the events wanted based on the fields * `event_type` * `operation` * `source_plugin_mount` * `full_secret_path` * `namespace` Example expressions: These can be passed to `vault events subscribe`, e.g.,: * `event_type == abc` * `source_plugin_mount == secret/` * `event_type != def and operation != write` ```sh vault events subscribe -filter='source_plugin_mount == secret/' 'kv*' ``` The docs for the `vault events subscribe` command and API endpoint will be coming shortly in a different PR, and will include a better specification for these expressions, similar to (or linking to) https://developer.hashicorp.com/boundary/docs/concepts/filtering
swenson
force-pushed
the
vault-19136/events-b-expr
branch
from
f496554 to
23b9d41
Compare
|
Thanks! |
|
Not sure how, but it looks like the build in http/events_test.go broke since this got merged: https://github.com/hashicorp/vault/actions/runs/6114328001/job/16595812688 |
swenson
pushed a commit
that referenced
this pull request
Sep 7, 2023
When #22835 was merged, it was auto-squashed, so the `experiments` import was removed, but the test still referenced it. This removes the (now unnecessary) experiment from the test.
swenson
pushed a commit
that referenced
this pull request
Sep 7, 2023
When #22835 was merged, it was auto-squashed, so the `experiments` import was removed, but the test still referenced it. This removes the (now unnecessary) experiment from the test.
swenson
pushed a commit
that referenced
this pull request
Sep 7, 2023
When #22835 was merged, it was auto-squashed, so the `experiments` import was removed, but the test still referenced it. This removes the (now unnecessary) experiment from the test.
swenson
pushed a commit
that referenced
this pull request
Sep 7, 2023
…ons into release/1.15.x (#22872) * backport of commit 022469d * Fix auto-squash events experiments (#22876) When #22835 was merged, it was auto-squashed, so the `experiments` import was removed, but the test still referenced it. This removes the (now unnecessary) experiment from the test. --------- Co-authored-by: Christopher Swenson <[email protected]>
sgmiller
added a commit
that referenced
this pull request
Sep 8, 2023
* Ignore nonces when encrypting without convergence or with convergence versions > 1 * Honor nonce use warning in non-FIPS modes * Revert "Honor nonce use warning in non-FIPS modes" This reverts commit 2aee3db. * Add a test func that removes a nonce when not needed * err out rather than ignore the nonce * Alter unit test to cover, also cover convergent version 3 * More unit test work * Fix test 14 * changelog * tests not already in a nonce present path * Update unit test to not assume warning when nonce provided incorrectly * remove unused test field * Fix auto-squash events experiments When #22835 was merged, it was auto-squashed, so the `experiments` import was removed, but the test still referenced it. This removes the (now unnecessary) experiment from the test. * Allow nonces for managed keys, because we have no way of knowing if the backing cipher/mode needs one --------- Co-authored-by: Christopher Swenson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subscribing to events through a WebSocket now support boolean expressions to filter only the events wanted based on the fields
event_typeoperationsource_plugin_mountdata_pathnamespaceExample expressions:
These can be passed to
vault events subscribe, e.g.,:event_type == abcsource_plugin_mount == secret/event_type != def and operation != writeThe docs for the
vault events subscribecommand and API endpoint will be coming shortly in a different PR, and will include a better specification for these expressions, similar to (or linking to) https://developer.hashicorp.com/boundary/docs/concepts/filtering