events: Add support for multi-namespace subscriptions #22540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
swenson
force-pushed
the
vault-19221/events-namespaces
branch
from
542bf43 to
3295519
Compare
|
Build Results: |
|
CI Results: |
tomhjp
reviewed
Aug 24, 2023
tomcf-hcp
reviewed
Aug 24, 2023
|
I added the logic around validating child namespaces. PTAL. |
swenson
force-pushed
the
vault-19221/events-namespaces
branch
from
b5b6c3f to
c573775
Compare
tomhjp
reviewed
Aug 25, 2023
swenson
force-pushed
the
vault-19221/events-namespaces
branch
from
c573775 to
9dfe2c1
Compare
Events from multiple namespaces can be subscribed to via glob patterns passed to the subscription. This does not do policy enforcement yet -- that will come in PR soon. I tested this manually as well by pulling it into Vault Enterprise so I could create namespaces and check that subscriptions work as expected.
Co-authored-by: Tom Proctor <[email protected]>
Co-authored-by: Tom Proctor <[email protected]>
Co-authored-by: Tom Proctor <[email protected]>
Co-authored-by: Tom Proctor <[email protected]>
swenson
force-pushed
the
vault-19221/events-namespaces
branch
from
618a23b to
b6f56c5
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Events from multiple namespaces can be subscribed to via glob patterns passed to the subscription.
This does not do policy enforcement yet -- that will come in another PR soon.
I tested this manually as well by pulling it into Vault Enterprise so I could create namespaces and check that subscriptions work as expected.