UI: Fix InfoTableRow args so row value renders with copyable tooltip #22519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malinac02
added
ui
hashicorp-contributed-pr
|
CI Results: |
|
Build Results: |
hellobontempo
requested changes
Aug 23, 2023
|
It's helpful that you referenced Something like - |
malinac02
changed the title
malinac02
deleted the
ui/VAULT-19295/update-InfoTableRow-with-Ember-Octane-syntax
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The component
<InfoTableRow>is a glimmer component, not a classic component, but some arguments in the handlebars file are still referred to in the classic Ember way. As a result, there is a problem where the "Last Vault Rotation" timestamp for static database roles is not rendering or copyableThis PR fixes this bug.