Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subscribe capability to policies #22474

Merged
merged 4 commits into from
Aug 22, 2023
Merged

Conversation

swenson
Copy link
Contributor

@swenson swenson commented Aug 21, 2023

... and subscribe_event_types to the policy body.

These are not currently enforced in the events system (as that will require populating the full secrets path in the event).

Documentation for subscribe_event_types will come in a future PR, probably in the events docs?

@swenson swenson requested review from tomhjp and a team August 21, 2023 17:59
@swenson swenson requested a review from a team as a code owner August 21, 2023 17:59
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Aug 21, 2023
@swenson swenson added this to the 1.15 milestone Aug 21, 2023
@github-actions
Copy link

Build Results:
All builds succeeded! ✅

@github-actions
Copy link

CI Results:
All Go tests succeeded! ✅

Copy link
Contributor

@tomhjp tomhjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

website/content/docs/concepts/policies.mdx Outdated Show resolved Hide resolved
Christopher Swenson and others added 4 commits August 22, 2023 10:50
... and `subscribe_event_types` to the policy body.

These are not currently enforced in the events system (as that
will require populating the full secrets path in the event).

Documentation for `subscribe_event_types` will come in a future PR,
probably in the events docs?
@swenson swenson force-pushed the vault-16985/subscribe-capability branch from cf26217 to c0f5668 Compare August 22, 2023 17:50
@swenson
Copy link
Contributor Author

swenson commented Aug 22, 2023

Thanks!

@swenson swenson enabled auto-merge (squash) August 22, 2023 17:50
@swenson swenson merged commit 12fc5be into main Aug 22, 2023
@swenson swenson deleted the vault-16985/subscribe-capability branch August 22, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants