-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VAULT-14644 Add support for Azure WIF auth to auto-auth (for Agent and Proxy) #22264
Conversation
CI Results: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM added a few suggestions 😄
// getTokenFromIdentityEndpoint is kept for backwards compatibility purposes. Using the | ||
// newer APIs and the Azure SDK should be preferred over this mechanism. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// getTokenFromIdentityEndpoint is kept for backwards compatibility purposes. Using the | |
// newer APIs and the Azure SDK should be preferred over this mechanism. | |
// getTokenFromIdentityEndpoint is kept for backwards compatibility purposes. Using the | |
// newer APIs and the Azure SDK should be preferred over this mechanism. | |
// Deprecated: use getAzureTokenFromEnvironment. |
Should we mark this with deprecated to give folks a warning in their IDE?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know that it's deprecated, per se - it's the 'old'/'legacy' way of doing things but I don't think it's deprecated from a Vault-product standpoint or an Azure product standpoint.
website/content/docs/agent-and-proxy/autoauth/methods/azure.mdx
Outdated
Show resolved
Hide resolved
website/content/docs/agent-and-proxy/autoauth/methods/azure.mdx
Outdated
Show resolved
Hide resolved
website/content/docs/agent-and-proxy/autoauth/methods/azure.mdx
Outdated
Show resolved
Hide resolved
Build Results: |
…d Proxy) (#22264) * VAULT-14644 first draft of changes for WIF support * VAULT-14644 Potentially finalize Agent work for WIF support * VAULT-14644 finishing touches * VAULT-14644 finishing touches * VAULT-14644 remove extra log * VAULT-14644 better docs * VAULT-14644 changelog * VAULT-14644 review feedback
This, together with the plugin changes included in the go.mod, should enable Vault Agent and Proxy to use Azure Workload Identity Federation for authentication.
I used the following for a successful WIF login:
Tested in our legacy Azure tenant with Vault and Agent running in K8S, with WIF enabled, e.g.:
I couldn't see a good way to test these changes, as it essentially entirely relies on Azure APIs. We don't have any right now, either, likely for similar reasons. I'm open to suggestions, but I worry it might get mock-crazy.