Remove "expiration manager is nil on tokenstore" error log for dr secondary #22137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
|
Build Results: |
|
CI Results: |
akshya96
added a commit
that referenced
this pull request
Jul 31, 2023
…ondary (#22137) * add check for dr secondary case * add changelog
akshya96
added a commit
that referenced
this pull request
Jul 31, 2023
…ondary (#22137) (#22139) * add check for dr secondary case * add changelog Co-authored-by: akshya96 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://hashicorp.atlassian.net/browse/VAULT-18066
Prudential log findings: https://docs.google.com/document/d/17FBuLY6Ce584XOjLH2Kfen9Si9_xXFGQwha1bvb0qhY/edit#bookmark=id.ehl8pojz06uk
On DR secondary when we have unauth requests with some token being set in req.ClientToken (not root/ batch token), we log the error "expiration manager is nil on tokenstore". We have this check in lookupInternal to check if we are still restoring the expiration manager as we want to ensure that the token is not expired but DR secondaries do not have expiration manager https://github.com/hashicorp/vault/blob/8253e59752751ce44284ef45130776c2b2812231/vault/token_store.go#L1694C1-L1697C1.
This error is just logged but the command never fails because in CheckToken function, we ignore these errors as non-errors for unauth requests as we do not expect a token for unauth requests https://github.com/hashicorp/vault/blob/8253e59752751ce44284ef45130776c2b2812231/vault/request_handling.go#L281C1-L287C1.
Most of the paths for auth requests are disabled for DR secondary mode so this will not fail in case of auth requests.
This PR removes this error log for DR secondaries.