-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Add example modal to policy form #21583
Conversation
…desription to policy-example.js
…oved functionality from policy-template.js (it is already in policy-example.js)
…dal for when editing a policy
… and (2) properly rendering the policy example modal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!! Some minor cleanup comments, and we just need to add the third policy sample!
…le, changed wording in policy-form-test.js
…selectors in the test file
… from .hbs to .js file and vise versa
…ount for new EGP policy
Build Results: |
CI Results: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really great work on this! Let's hold of merging until someone else has reviewed, but looks great to me! ⭐
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Nice work 🚢
Add example modal to policy form
Description:
Images:
Before:
After: