Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Add example modal to policy form #21583

Merged
merged 19 commits into from
Jul 20, 2023
Merged

Conversation

malinac02
Copy link
Contributor

@malinac02 malinac02 commented Jul 5, 2023

Add example modal to policy form

Description:

  • In create policy, clicking "example template" renders a modal with the corresponding policy example.
    • Modal is also available when editing an already-existing policy
  • Modal is not available when creating a policy is already a modal. When this is the case, the policy example is still available via another tab (for example, creating a policy through Access/Entities)
  • Beneath the policy example, there is a link to more information about that policy type
    • This link is available under the policy example both when it is displayed in the modal and when it is displayed as a tab

Images:
Before:
Before

After:
After
After2

@malinac02 malinac02 added the ui label Jul 5, 2023
@malinac02 malinac02 requested a review from kiannaquach July 5, 2023 17:11
@malinac02 malinac02 added this to the 1.15 milestone Jul 5, 2023
@VioletHynes VioletHynes added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jul 7, 2023
@malinac02 malinac02 marked this pull request as ready for review July 11, 2023 00:17
Copy link
Contributor

@hellobontempo hellobontempo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!! Some minor cleanup comments, and we just need to add the third policy sample!

ui/app/components/policy-form.hbs Show resolved Hide resolved
ui/lib/core/addon/components/policy-example.js Outdated Show resolved Hide resolved
ui/tests/integration/components/policy-form-test.js Outdated Show resolved Hide resolved
ui/lib/core/addon/components/policy-example.hbs Outdated Show resolved Hide resolved
ui/lib/core/addon/components/policy-example.js Outdated Show resolved Hide resolved
ui/lib/core/addon/components/policy-example.hbs Outdated Show resolved Hide resolved
@malinac02 malinac02 requested a review from hellobontempo July 18, 2023 20:26
@github-actions
Copy link

Build Results:
All builds succeeded! ✅

@github-actions
Copy link

github-actions bot commented Jul 18, 2023

CI Results:
All Go tests succeeded! ✅

@malinac02 malinac02 requested a review from hellobontempo July 19, 2023 19:20
Copy link
Contributor

@hellobontempo hellobontempo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great work on this! Let's hold of merging until someone else has reviewed, but looks great to me! ⭐

Copy link
Contributor

@Monkeychip Monkeychip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Nice work 🚢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants