-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add API Explorer Link to Sidebar Nav under tools #21578
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea adding a link to the api explorer in the tools nav! Just a comment regarding some cleanup on the link but otherwise looks good.
@route="vault.cluster.tools.open-api-explorer.index" | ||
@current-when="vault.cluster.tools.open-api-explorer.index" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pulled down the branch to test and you can remove .index
from the route and also current-when
is not necessary since the link only needs to be active when the route is navigated to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for checking. I'll update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
This PR adds the API Explorer link to the sidebar nav, under tools. Previously the only way to open this link was to type "api" into the dev console; an unnecessary easter egg.
open-api-explorer.mov