-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix re-migration of existing CA bundles #21316
Fix re-migration of existing CA bundles #21316
Conversation
Related: VAULT-17307 Signed-off-by: Alexander Scheel <[email protected]>
Signed-off-by: Alexander Scheel <[email protected]>
Signed-off-by: Alexander Scheel <[email protected]>
Signed-off-by: Alexander Scheel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made some editorial suggestions to improve content accessibility. Let me know if you have any questions :)
> failed to lookup public key from managed key: | ||
> no managed key found with uuid | ||
|
||
This has been fixed in Vault 1.14.0, 1.13.4, 1.12.8, and 1.11.12. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been fixed in Vault 1.14.0, 1.13.4, 1.12.8, and 1.11.12. |
Suggest deleting this line and making the information easier to find by highlighting it at the beginning.
Co-authored-by: Sarah Chavis <[email protected]>
Co-authored-by: Sarah Chavis <[email protected]>
Signed-off-by: Alexander Scheel <[email protected]>
@schavis Mind re-reviewing with the updates? Thanks! |
Signed-off-by: Alexander Scheel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor tweaks for active voice
Co-authored-by: Sarah Chavis <[email protected]>
Co-authored-by: Sarah Chavis <[email protected]>
Later in Vault 1.11, 1.12, and 1.13's release, we added a fix for a regression regarding chain building that resulted in a small migration to rebuild all issuer's chains within the mount. This resulted in a second storage migration "version" being created, which was unfortunate as the existing logic resulted in the entire migration being re-attempted:
As a result, if the migrated legacy issuers (from storage version 0/1) were deleted prior to version 2's upgrade (to 1.13.0, 1.12.2, and 1.11.6), these would be recreated and would need to be removed again. Additionally, when managed keys were in use (in Vault Enterprise), an error like:
would be visible in the logs. This only affects issuers created prior to upgrading to Vault 1.11.
Related: VAULT-17307