Duplicate groups creation bug #20964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncabatoff
approved these changes
Jun 2, 2023
ncabatoff
approved these changes
Jun 2, 2023
This was referenced Jun 2, 2023
akshya96
added a commit
that referenced
this pull request
Jun 2, 2023
* fix duplicate groups creation * add changelog
akshya96
added a commit
that referenced
this pull request
Jun 2, 2023
* fix duplicate groups creation * add changelog
akshya96
added a commit
that referenced
this pull request
Jun 2, 2023
* fix duplicate groups creation * add changelog
akshya96
added a commit
that referenced
this pull request
Jun 8, 2023
* fix duplicate groups creation * add changelog Co-authored-by: akshya96 <[email protected]>
akshya96
added a commit
that referenced
this pull request
Jun 8, 2023
* fix duplicate groups creation * add changelog Co-authored-by: akshya96 <[email protected]>
akshya96
added a commit
that referenced
this pull request
Jun 8, 2023
* Duplicate groups creation bug (#20964) * fix duplicate groups creation * add changelog * make fmt --------- Co-authored-by: akshya96 <[email protected]> Co-authored-by: akshya96 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hashicorp.atlassian.net/browse/VAULT-16649
Vault does not prevent the creation of duplicate groups when multiple "create group" requests with the same group name are sent simultaneously to different nodes. The issue arises because Vault relies on the view of MemDB from IdentityStore, which is independent for each node, to check for the presence of another group with the same name. As a result, when requests occur within a short time frame, the MemDB on each node may not have the group names.
Currently, the request is only forwarded to the active node for writing to storage based on the ID i.e, as part of UpsertGroupInTxn function, we would only forward the write to storage request using SendGroupUpdate https://github.com/hashicorp/vault-enterprise/blob/5e4c01ae563d2ad3f4138171e95cb6bdb2ee9e20/vault/identity_store_util.go#LL1826C1-L1834C4.
Approved ent PR: https://github.com/hashicorp/vault-enterprise/pull/4137