Backport of Transit BYOK export capabilities into release/1.14.x #20877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-secure-vault-core
force-pushed
the
backport/cipherboy-transit-byok/plainly-thorough-termite
branch
2 times, most recently
from
e998c53 to
b4c2c9e
Compare
…ainly-thorough-termite
cipherboy
approved these changes
May 30, 2023
cipherboy
deleted the
backport/cipherboy-transit-byok/plainly-thorough-termite
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #20736 to be assessed for backporting due to the inclusion of the label backport/1.14.x.
The below text is copied from the body of the original PR.
This still needs tests, but this adds the bulk of the work to support BYOK exporting of keys, now that #17934 has landed.
In particular, the combination of the two features allows an operator to securely establish key material between two separate Transit installations. This potentially allows one cluster to be used as a source cluster (encrypting a large amount of data) and a second cluster to decrypt this data later. This might be useful in hybrid or site-specific deployments of Vault for instance.
I want to make additional changes to
bump_versionbefore release, and wanted a way of testing export + import of keys easily, plus wanted to enable this particular use case.In the future, it might be nice to move
UnwrapKeyinto the shared namespace as well, now thattinkis added as a formal dependency.TODO in this PR:
Overview of commits