UI: Transit Key TTL not initializing to toggled off

changelog/20731.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+ui: fixes auto_rotate_period ttl input for transit keys
+```

ui/app/templates/components/transit-form-create.hbs

@@ -1,4 +1,4 @@
-<form onsubmit={{@createOrUpdateKey}}>
+<form data-test-transit-create-form onsubmit={{@createOrUpdateKey}}>
   <div class="box is-sideless is-fullwidth is-marginless">
     <MessageError @model={{@key}} />
     <NamespaceReminder @mode="create" @noun="transit key" />

ui/app/templates/components/transit-form-edit.hbs

@@ -1,4 +1,4 @@
-<form onsubmit={{@createOrUpdateKey}}>
+<form data-test-transit-edit-form onsubmit={{@createOrUpdateKey}}>
   <div class="box is-sideless is-fullwidth is-marginless">
     <MessageError @model={{@key}} />
     <NamespaceReminder @mode="edit" @noun="transit key" />
@@ -19,7 +19,7 @@
     <div class="field">
       <TtlPicker
         @initialValue={{or @key.autoRotatePeriod "30d"}}
-        @initialEnabled={{not (eq @key.autoRotatePeriod "0s")}}
+        @initialEnabled={{not (eq @key.autoRotatePeriod 0)}}
         @label="Auto-rotation period"
         @helperTextDisabled="Key will never be automatically rotated"
         @helperTextEnabled="Key will be automatically rotated every"

ui/app/templates/components/transit-form-show.hbs

@@ -171,7 +171,7 @@
   <InfoTableRow @label="Type" @value={{@key.type}} />
   <InfoTableRow
     @label="Auto-rotation period"
-    @value={{or (format-duration @key.autoRotatePeriod nullable=true) "Key will not be automatically rotated"}}
+    @value={{or (format-duration @key.autoRotatePeriod) "Key will not be automatically rotated"}}
   />
   <InfoTableRow @label="Deletion allowed" @value={{stringify @key.deletionAllowed}} />
 

ui/tests/integration/components/transit-edit-test.js

@@ -0,0 +1,105 @@
+import { module, test } from 'qunit';
+import { setupRenderingTest } from 'vault/tests/helpers';
+import { click, fillIn, render } from '@ember/test-helpers';
+import { hbs } from 'ember-cli-htmlbars';
+
+const SELECTORS = {
+  createForm: '[data-test-transit-create-form]',
+  editForm: '[data-test-transit-edit-form]',
+  ttlToggle: '[data-test-ttl-toggle="Auto-rotation period"]',
+  ttlValue: '[data-test-ttl-value="Auto-rotation period"]',
+};
+module('Integration | Component | transit-edit', function (hooks) {
+  setupRenderingTest(hooks);
+
+  hooks.beforeEach(function () {
+    this.store = this.owner.lookup('service:store');
+    this.model = this.store.createRecord('transit-key');
+    this.backendCrumb = {
+      label: 'transit',
+      text: 'transit',
+      path: 'vault.cluster.secrets.backend.list-root',
+      model: 'transit',
+    };
+  });
+
+  test('it renders in create mode and updates model', async function (assert) {
+    await render(hbs`
+    <TransitEdit 
+      @key={{this.model}}
+      @model={{this.model}}
+      @mode="create"
+      @root={{this.backendCrumb}}
+      @preferAdvancedEdit={{false}}
+    />`);
+
+    assert.dom(SELECTORS.createForm).exists();
+    assert.dom(SELECTORS.ttlToggle).isNotChecked();
+
+    // confirm model params update when ttl changes
+    assert.strictEqual(this.model.autoRotatePeriod, '0');
+    await click(SELECTORS.ttlToggle);
+
+    assert.dom(SELECTORS.ttlValue).hasValue('30'); // 30 days
+    assert.strictEqual(this.model.autoRotatePeriod, '720h');
+
+    await fillIn(SELECTORS.ttlValue, '10'); // 10 days
+    assert.strictEqual(this.model.autoRotatePeriod, '240h');
+  });
+
+  test('it renders edit form correctly when key has autoRotatePeriod=0', async function (assert) {
+    this.model.autoRotatePeriod = 0;
+    this.model.keys = {
+      1: 1684882652000,
+    };
+    await render(hbs`
+      <TransitEdit 
+        @key={{this.model}}
+        @model={{this.model}}
+        @mode="edit"
+        @root={{this.backendCrumb}}
+        @preferAdvancedEdit={{false}}
+      />`);
+
+    assert.dom(SELECTORS.editForm).exists();
+    assert.dom(SELECTORS.ttlToggle).isNotChecked();
+
+    assert.strictEqual(this.model.autoRotatePeriod, 0);
+
+    await click(SELECTORS.ttlToggle);
+    assert.dom(SELECTORS.ttlToggle).isChecked();
+    assert.dom(SELECTORS.ttlValue).hasValue('30');
+    assert.strictEqual(this.model.autoRotatePeriod, '720h', 'model value changes with toggle');
+
+    await click(SELECTORS.ttlToggle);
+    assert.strictEqual(this.model.autoRotatePeriod, 0); // reverts to original value when toggled back on
+  });
+
+  test('it renders edit form correctly when key has non-zero rotation period', async function (assert) {
+    this.model.autoRotatePeriod = '5h';
+    this.model.keys = {
+      1: 1684882652000,
+    };
+    await render(hbs`
+      <TransitEdit 
+        @key={{this.model}}
+        @model={{this.model}}
+        @mode="edit"
+        @root={{this.backendCrumb}}
+        @preferAdvancedEdit={{false}}
+      />`);
+
+    assert.dom(SELECTORS.editForm).exists();
+    assert.dom(SELECTORS.ttlToggle).isChecked();
+
+    await click(SELECTORS.ttlToggle);
+    assert.dom(SELECTORS.ttlToggle).isNotChecked();
+    assert.strictEqual(this.model.autoRotatePeriod, 0, 'model value changes back to 0 when toggled off');
+
+    await click(SELECTORS.ttlToggle);
+    assert.strictEqual(this.model.autoRotatePeriod, '5h'); // reverts to original value when toggled back on
+
+    await fillIn(SELECTORS.ttlValue, '10');
+    assert.strictEqual(this.model.autoRotatePeriod, '10h');
+  });
+});