agent: Add logic to validate env_template entries in configuration #20569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhuckins
approved these changes
May 15, 2023
dhuckins
reviewed
May 15, 2023
Co-authored-by: Anton Averchenkov <[email protected]>
Co-authored-by: Anton Averchenkov <[email protected]>
Signed-off-by: Daniel Huckins <[email protected]>
Signed-off-by: Daniel Huckins <[email protected]>
Signed-off-by: Daniel Huckins <[email protected]>
Signed-off-by: Daniel Huckins <[email protected]>
Signed-off-by: Daniel Huckins <[email protected]>
Signed-off-by: Daniel Huckins <[email protected]>
Signed-off-by: Daniel Huckins <[email protected]>
Signed-off-by: Daniel Huckins <[email protected]>
dhuckins
reviewed
May 19, 2023
VioletHynes
reviewed
May 19, 2023
VioletHynes
reviewed
May 19, 2023
VioletHynes
reviewed
May 23, 2023
VioletHynes
reviewed
May 23, 2023
command/agent/config/test-fixtures/bad-config-env-templates-disalowed-fields.hcl
Outdated
Show resolved
Hide resolved
VioletHynes
approved these changes
May 23, 2023
averche
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds logic to validate that the given agent configuration with
env_templateor top levelexecentries is valid. It is part of the larger effort to add environment variable support within Vault Agent (VLT-253).In brief, the following rules are ascertained as part of validation:
execmust be present if at least oneenv_templateentry is specified and vice-versatemplateandapi_proxyare not compatible withenv_templateentriesenv_templateonly allows a subset of file template fields (currently only the name,contents, anderror_on_missing_key), all other fields will result in a validation error.Related PRs: