Upgrade go-jose library to v3 #20559
Conversation
|
|
sagikazarmark
force-pushed
the
upgrade-go-jose
branch
2 times, most recently
from
46752ae to
599d68b
Compare
|
Many thanks for this, @sagikazarmark! Are you interested in another PR for the rest of Vault (the core server implementation)? |
|
Ah yes, we can't update just the API's version without bumping it in the main I think |
|
Sure, let me take a look. |
sagikazarmark
force-pushed
the
upgrade-go-jose
branch
from
599d68b to
54bb56b
Compare
|
@cipherboy ran go mod tidy. |
Maybe just do it all in this PR? It would be a bit weird to prioritize updating the single use-case in |
|
@maxb updated all occurrences in Vault code as well. The remaining imports are due to references to older versions of the api: |
There was a problem hiding this comment.
This looks good from my side. It appears the remaining usage of go-jose v2 is in the Okta plugin:
[cipherboy@xps15 okta]$ go mod why gopkg.in/square/go-jose.v2
# gopkg.in/square/go-jose.v2
github.com/hashicorp/vault/builtin/credential/okta
github.com/okta/okta-sdk-golang/v2/okta
gopkg.in/square/go-jose.v2
@miagilepner / @hghaf099, do either of you two know if there's a later version of okta-sdk-golang that uses go-jose v3?
|
@cipherboy doesn't look like it. I'm gonna send a PR to them as well, but I don't think that should be a blocker (not at least for merging the PR/an API release). Auth libraries will also have the old jose library as a reference, until the API is updated: https://github.com/hashicorp/vault/tree/main/api/auth |
Signed-off-by: Mark Sagi-Kazar <[email protected]>
Signed-off-by: Mark Sagi-Kazar <[email protected]>
Signed-off-by: Mark Sagi-Kazar <[email protected]>
sagikazarmark
force-pushed
the
upgrade-go-jose
branch
from
8a7b203 to
a94d942
Compare
|
@cipherboy @maxb anything else I need to do to get this merged? Thanks! |
Signed-off-by: Alexander Scheel <[email protected]>
|
@sagikazarmark Many thanks for the ping :-) I've pushed a changelog entry for this one and set this to auto-merge. |
|
@sagikazarmark Thank you for the PR! I've subscribed to the Okta PR so I'll get a reminder to update when that one merges. |
|
Perfect! Thanks! |
|
@cipherboy any ETA for the next API release? |
|
@sagikazarmark I'm not sure the exact date, but within the coming weeks I'd expect: #20808 |
|
Thanks! |
go-jose v2 is EOL as of 27 February: https://github.com/square/go-jose
This PR upgrades the API to use v3 of the library: https://github.com/go-jose/go-jose