VAULT-12226: Add Static Roles to the AWS plugin #20536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpcraig
changed the title
robmonte
reviewed
May 12, 2023
raymonstah
reviewed
May 16, 2023
fairclothjm
reviewed
May 16, 2023
fairclothjm
reviewed
May 16, 2023
fairclothjm
reviewed
May 16, 2023
fairclothjm
reviewed
May 16, 2023
fairclothjm
reviewed
May 16, 2023
fairclothjm
reviewed
May 16, 2023
vinay-gopalan
approved these changes
May 23, 2023
fairclothjm
reviewed
May 24, 2023
fairclothjm
reviewed
May 24, 2023
yhyakuna
approved these changes
May 24, 2023
fairclothjm
approved these changes
May 24, 2023
vinay-gopalan
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability for the aws engine to manage static roles, analogous to the way we do it in the various database plugins.
In this PR we provide two new endpoints at
<aws>/static-rolesand<aws>/static-creds.At
static-roles/<name>, we provide a read/write/delete set for specifying a new static role that points at an existing IAM User, which the aws engine will then adopt and manage. (I apologize for the slightly mismatched terminology here).At
static-creds/<name>we provide a read route that will return the current aws credential for the managed user.Under the hood, we place newly created roles into a priority queue ordered by time left until rotation, and assign a backend
PeriodicFuncto handle all roles past rotation time and requeue for the next rotation.