Fix panic when Vault enters recovery mode, added test #20418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peteski22
added
bug
ncabatoff
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes regression in recovery mode where Vault panics, the bug was introduced by log rotation features (1.13) and this PR should correct the issue.
We're no longer calling
.Flags()which already happens at the top of ourServer.Runfunc, and instead accessing the relevant field (.flags). A test case has been added to verify recovery mode (and a flag check which matches the vanillaServer.Runpath added withinrunRecoveryMode).Thanks to folks for reporting and assisting with identifying the issue 👍🏼
Closes #20396