Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidebar Navigation Components #19446

Merged
merged 8 commits into from
Mar 16, 2023
Merged

Sidebar Navigation Components #19446

merged 8 commits into from
Mar 16, 2023

Conversation

zofskeez
Copy link
Contributor

@zofskeez zofskeez commented Mar 2, 2023 •
edited
Loading

Adds components for sidebar frame and navigation links. A follow up PR will be opened to add the components in the template and clean up any components that are no longer needed.

For the nav components, I pulled the links directly from existing templates that used the MenuSidebar component. The nav cluster component also took links from the ClusterInfo component.

Note that the test run will fail until the nav addon is published since it is linked locally

@zofskeez zofskeez added this to the 1.14 milestone Mar 2, 2023
zofskeez
zofskeez commented Mar 16, 2023
View reviewed changes
ui/app/components/sidebar/user-menu.hbs Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is basically the menu from the auth-info component with a couple of minor tweaks to match designs.

zofskeez
zofskeez commented Mar 16, 2023
View reviewed changes
ui/app/templates/application.hbs Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to move the wormhole higher up to prepare for the sidebar frame component and moving the link-status component out of the cluster template.

@Monkeychip
Copy link
Contributor

Looks good to me, a couple of questions, and one request for Screenshots? Helps us if we ever need to come back to this PR what part of the project you were focusing on. Nothing detailed, but an idea at first glance where we are.

Monkeychip
Monkeychip reviewed Mar 16, 2023
View reviewed changes
ui/app/styles/components/sidebar.scss Outdated
text-transform: unset;
}
.token-alert {
padding: 8px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can however be $spacing-xs (comes from the _spacing.scss)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find I updated it!

@zofskeez
Copy link
Contributor Author

Looks good to me, a couple of questions, and one request for Screenshots? Helps us if we ever need to come back to this PR what part of the project you were focusing on. Nothing detailed, but an idea at first glance where we are.

I broke up the work into 2 branches because I thought it was getting too big for one PR which is why this is just components. On this branch there isn't anything to look at in the app bu in the follow up PR I'll have screenshots of all the different sidebars. I'll come back and link to it in the description.

@zofskeez zofskeez marked this pull request as ready for review March 16, 2023 20:33
@zofskeez zofskeez merged commit 79f1ce4 into ui/VAULT-12799/sidebar-navigation Mar 16, 2023
@zofskeez zofskeez deleted the ui/VAULT-13632/sidebar-nav-component branch March 16, 2023 20:45
@zofskeez zofskeez mentioned this pull request Mar 17, 2023
Merged
zofskeez added a commit that referenced this pull request May 3, 2023
@zofskeez
Sidebar Navigation (#19296)
9d8ba3a 
* Add Helios Design System Components (#19278)

* adds hds dependency

* updates reset import path

* sets minifyCSS advanced option to false

* Remove node-sass (#19376)

* removes node-sass and fixes sass compilation

* fixes active tab li class

* Sidebar Navigation Components (#19446)

* links ember-shared-components addon and imports styles

* adds sidebar frame and nav components

* updates HcNav component name to HcAppFrame and adds sidebar UserMenu component

* adds tests for sidebar components

* fixes tests

* updates user menu styling

* fixes typos in nav cluster component

* changes padding value in sidebar stylesheet to use variable

* Replace and remove old nav components with new ones (#19447)

* links ember-shared-components addon and imports styles

* adds sidebar frame and nav components

* updates activeCluster on auth service and adds activeSession prop for sidebar visibility

* replaces old nav components with new ones in templates

* fixes sidebar visibility issue and updates user menu label class

* removes NavHeader usage

* adds clients index route to redirect to dashboard

* removes unused HcAppFrame footer block and reduces page header top margin

* Nav component cleanup (#19681)

* removes nav-header components

* removes navbar styling

* removes status-menu component and styles

* removes cluster and auth info components

* removes menu-sidebar component and styling

* fixes tests

* Console Panel Updates (#19741)

* updates console panel styling

* adds test for opening and closing the console panel

* updates console panel background color to use hds token

* adds right margin to console panel input

* updates link-status banner styling

* updates hc nav components to new API

* Namespace Picker Updates (#19753)

* updates namespace-picker

* updates namespace picker menu styling

* adds bottom margin to env banner

* updates class order on namespace picker link

* restores manage namespaces refresh icon

* removes manage namespaces nav icon

* removes home link component (#20027)

* Auth and Error View Updates (#19749)

* adds vault logo to auth page

* updates top level error template

* updates loading substate handling and moves policies link from access to cluster nav (#20033)

* moves console panel to bottom of viewport (#20183)

* HDS Sidebar Nav Components (#20197)

* updates nav components to hds

* upgrades project yarn version to 3.5

* fixes issues in app frame component

* updates sidenav actions to use icon button component

* Sidebar navigation acceptance tests (#20270)

* adds sidebar navigation acceptance tests and fixes other test failures

* console panel styling tweaks

* bumps addon version

* remove and ignore yarn install-state file

* fixes auth service and console tests

* moves classes from deleted files after bulma merge

* fixes sass syntax errors blocking build

* cleans up dart sass deprecation warnings

* adds changelog entry

* hides namespace picker when sidebar nav panel is minimized

* style tweaks

* fixes sidebar nav tests

* bumps hds addon to latest version and removes style override

* updates modify-passthrough-response helper

* updates sidebar nav tests

* mfa-setup test fix attempt

* fixes cluster mfa setup test

* remove deprecated yarn ignore-optional flag from makefile

* removes another instance of yarn ignore-optional and updates ui readme

* removes unsupported yarn verbose flag from ci-helper

* hides nav headings when user does not have access to any sub links

* removes unused optional deps and moves lint-staged to dev deps

* updates has-permission helper and permissions service tests

* fixes issue with console panel not filling container width
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Monkeychip Monkeychip Monkeychip approved these changes

Assignees
No one assigned
Labels
pr/no-changelog ui
Projects
None yet
Milestone
1.14
Development

Successfully merging this pull request may close these issues.
2 participants
@zofskeez @Monkeychip