Configure Ember Data ID Generation #19428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // the uuid library was brought in to replace other usages of crypto in the app so it is safe to use in unsecure contexts | ||
| setIdentifierGenerationMethod((resource) => { | ||
| return resource.lid || uuidv4(); | ||
| // adapted from defaultGenerationMethod -- https://github.com/emberjs/data/blob/v4.5.0/packages/store/addon/-private/identifier-cache.ts#LL82-L94C2 |
There was a problem hiding this comment.
thanks for adding this!
hellobontempo
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ember Data started using the uuidv4 library for ID generation which uses
crypto.getRandomUUIDwhich is not available in unsecure contexts. There was a polyfill added in4.6.2, but until we can upgrade an initializer has been created to configure the id generation method using theuuidlibrary which was brought in to replacecryptoin our codebase.More information in this Ember Data issue