Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Use uuid dependency instead of crypto.randomUUID() #19410

Merged

Conversation

hellobontempo
Copy link
Contributor

@hellobontempo hellobontempo commented Feb 28, 2023

Similar to the changes made in #19403

This PR removes using the crypto interface which requires secure context MDN docs here and adds the uuid package since crypto is only available in secure contexts.

@hellobontempo hellobontempo added ui backport bug Used to indicate a potential bug labels Feb 28, 2023
@hellobontempo hellobontempo added this to the 1.12.4 milestone Feb 28, 2023
@hellobontempo
Copy link
Contributor Author

hellobontempo commented Feb 28, 2023

edit: This resolves the issue mentioned in the comment here

Copy link
Contributor

@zofskeez zofskeez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@hellobontempo hellobontempo enabled auto-merge (squash) February 28, 2023 21:33
@hellobontempo hellobontempo merged commit 0d09e84 into release/1.12.x Feb 28, 2023
@hellobontempo hellobontempo deleted the ui/backport-19403-remove-crypto.randomUUID branch February 28, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport bug Used to indicate a potential bug ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants