Parallel migration (#18815) #18817
Merged
Parallel migration (#18815) #18817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* flagParallel sanity check * Attempt to use ErrGroups * Updated docs Co-authored-by: Tomasz Pawelczak <[email protected]>
peteski22
added
docs
core
Co-authored-by: Mike Palmiotto <[email protected]>
hghaf099
reviewed
Jan 25, 2023
added 3 commits
January 25, 2023 12:50
* parallel flag renamed to max-parallel * tests for start + parallel * removed constraints for start flag and max-parallel flag being used together * Tweaked some wording
* Removed permit pool * Removed (re)check of max parallel value in dfsScan * Updated docs to make it clearer that a high setting might not be honored based on storage backend setting
ncabatoff
reviewed
Jan 25, 2023
ncabatoff
reviewed
Jan 25, 2023
ncabatoff
reviewed
Jan 25, 2023
ncabatoff
approved these changes
Jan 25, 2023
* Default max-parallel 1 => 10 * Docs updated * Test folder/paths updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to bring in an OSS contributor's work into Vault, to improve the speed of migration when using
vault operator migrate.Please see the following for further information:
Initial PR: #8857
PR to bring fork into a HashiCorp/Vault branch: #18815
Original Issue: #8883
Co-authored-by: Tomasz Pawelczak [email protected]