Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Explorer Query Params #18743

Merged
merged 2 commits into from
Jan 17, 2023
Merged

API Explorer Query Params #18743

merged 2 commits into from
Jan 17, 2023

Conversation

zofskeez
Copy link
Contributor

As mentioned in #18614, query parameters were not being passed in API explorer test requests due to a custom requestInterceptor which was not rebuilding the url with the query parameters.

Before
image

After
image

@zofskeez zofskeez added ui bug Used to indicate a potential bug backport/1.10.x labels Jan 17, 2023
@zofskeez zofskeez added this to the 1.10.11 milestone Jan 17, 2023
Copy link
Contributor

@hellobontempo hellobontempo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling! 🚢

@zofskeez zofskeez merged commit 72e515b into main Jan 17, 2023
@zofskeez zofskeez deleted the ui/VAULT-12583/api-explorer-query branch January 17, 2023 23:37
zofskeez added a commit that referenced this pull request Jan 18, 2023
* adds query params to api explorer test requests

* adds changelog entry
zofskeez added a commit that referenced this pull request Jan 18, 2023
* adds query params to api explorer test requests

* adds changelog entry
zofskeez added a commit that referenced this pull request Jan 18, 2023
* adds query params to api explorer test requests

* adds changelog entry
zofskeez added a commit that referenced this pull request Jan 18, 2023
* adds query params to api explorer test requests

* adds changelog entry
zofskeez added a commit that referenced this pull request Jan 18, 2023
* adds query params to api explorer test requests

* adds changelog entry
zofskeez added a commit that referenced this pull request Jan 18, 2023
* adds query params to api explorer test requests

* adds changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Used to indicate a potential bug ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants