VAULT-12144: add openapi responses for /sys/seal endpoints #18625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Huckins <[email protected]>
Signed-off-by: Daniel Huckins <[email protected]>
dhuckins
changed the title
dhuckins
changed the title
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
AnPucel
reviewed
Jan 10, 2023
| @@ -493,6 +499,77 @@ func (b *SystemBackend) rekeyPaths() []*framework.Path { | |||
| Operations: map[logical.Operation]framework.OperationHandler{ | |||
| logical.UpdateOperation: &framework.PathOperation{ | |||
| Summary: "Unseal the Vault.", | |||
| Responses: map[int][]framework.Response{ | |||
| http.StatusOK: {{ | |||
| // unseal returns `vault.SealStatusResponse` struct | |||
There was a problem hiding this comment.
I see warnings as a part of SealStatusResponse here. Should that get handled here too?
AnPucel
reviewed
Jan 10, 2023
| // unseal returns `vault.SealStatusResponse` struct | ||
| Fields: map[string]*framework.FieldSchema{ | ||
| "type": { | ||
| Type: framework.TypeString, |
There was a problem hiding this comment.
Do we want descriptions here? I believe it will affect code comments and intellisense when generating code
AnPucel
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UPDATEUPDATEREADN/A already donecouldn't find any tests (at least not in the same package)